Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Send a Gx-Version header set to __version__ in requests to cloud #5758

Merged
merged 7 commits into from Aug 16, 2022

Conversation

wookasz
Copy link
Contributor

@wookasz wookasz commented Aug 15, 2022

Changes proposed in this pull request:

  • Add Gx_Version: __version__ header when fetching data-context-configuration from cloud
  • Add Gx_Version: __version__ header when performing any CRUD operations against cloud stores

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@wookasz wookasz requested review from Kilo59 and cdkini August 15, 2022 16:58
@ghost
Copy link

ghost commented Aug 15, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 1ec8220
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62faec3705a0af000ad8d91b
😎 Deploy Preview https://deploy-preview-5758--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks reasonable.

Tests should pass if you update this fixture to include the new expected headers.
https://github.com/great-expectations/great_expectations/blob/develop/tests/data_context/conftest.py#L605-L610

@pytest.fixture
def request_headers(ge_cloud_access_token) -> Dict[str, str]:
    return {
        "Content-Type": "application/vnd.api+json",
        "Authorization": f"Bearer {ge_cloud_access_token}",
        "Gx-Version": __version__,
    }

* Fix RegexPatternStringParameterBuilder to use legal character repetition limits.  Remove median, mean, and standard deviation features from datetime rule. (#5757)

* [MAINTENANCE] Update `oneshot` estimator to `quantiles` estimator (#5737)

Update `oneshot` estimator to `quantiles` estimator

* [BUGFIX] Move `SuiteValidationResult.meta` validation id propogation before `ValidationOperator._run_action` (#5760)

* fix: move id up a few lines

* chore: add checkpoint id as well

* [MAINTENANCE] Update Auto-Initializing Expectations to use `exact` estimator by default (#5759)

* Update Auto-Initializing default to exact

* Update tests

* Send a Gx-Version header set to __version__ in requests to cloud

* Add Gx-Version header to test fixtures

* Fix import sort

* black

* use `request_headers` fixture

* remove `ge_cloud_runtime_access_token` for `ge_cloud_access_token`

Co-authored-by: Alex Sherstinsky <alexsherstinsky@users.noreply.github.com>
Co-authored-by: Nathan Farmer <NathanFarmer@users.noreply.github.com>
Co-authored-by: Chetan Kini <chetan@superconductive.com>
Co-authored-by: Łukasz Lempart <lukasz@superconductive.com>
@wookasz wookasz marked this pull request as ready for review August 15, 2022 23:47
@wookasz wookasz changed the title [MAINTENANCESend a Gx-Version header set to __version__ in requests to cloud [MAINTENANCE] Send a Gx-Version header set to __version__ in requests to cloud Aug 15, 2022
@Kilo59 Kilo59 self-assigned this Aug 16, 2022
@Kilo59 Kilo59 enabled auto-merge (squash) August 16, 2022 00:39
@Kilo59 Kilo59 merged commit 2537f8f into develop Aug 16, 2022
@Kilo59 Kilo59 deleted the maintenance/add_gx_version_header_to_cloud_requests branch August 16, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants