New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Send a Gx-Version header set to __version__ in requests to cloud #5758
[MAINTENANCE] Send a Gx-Version header set to __version__ in requests to cloud #5758
Conversation
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks reasonable.
Tests should pass if you update this fixture to include the new expected headers.
https://github.com/great-expectations/great_expectations/blob/develop/tests/data_context/conftest.py#L605-L610
@pytest.fixture
def request_headers(ge_cloud_access_token) -> Dict[str, str]:
return {
"Content-Type": "application/vnd.api+json",
"Authorization": f"Bearer {ge_cloud_access_token}",
"Gx-Version": __version__,
}
* Fix RegexPatternStringParameterBuilder to use legal character repetition limits. Remove median, mean, and standard deviation features from datetime rule. (#5757) * [MAINTENANCE] Update `oneshot` estimator to `quantiles` estimator (#5737) Update `oneshot` estimator to `quantiles` estimator * [BUGFIX] Move `SuiteValidationResult.meta` validation id propogation before `ValidationOperator._run_action` (#5760) * fix: move id up a few lines * chore: add checkpoint id as well * [MAINTENANCE] Update Auto-Initializing Expectations to use `exact` estimator by default (#5759) * Update Auto-Initializing default to exact * Update tests * Send a Gx-Version header set to __version__ in requests to cloud * Add Gx-Version header to test fixtures * Fix import sort * black * use `request_headers` fixture * remove `ge_cloud_runtime_access_token` for `ge_cloud_access_token` Co-authored-by: Alex Sherstinsky <alexsherstinsky@users.noreply.github.com> Co-authored-by: Nathan Farmer <NathanFarmer@users.noreply.github.com> Co-authored-by: Chetan Kini <chetan@superconductive.com> Co-authored-by: Łukasz Lempart <lukasz@superconductive.com>
Changes proposed in this pull request:
Gx_Version: __version__
header when fetchingdata-context-configuration
from cloudGx_Version: __version__
header when performing any CRUD operations against cloud storesAfter submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!