Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Cleanup of Regex ParameterBuilder #6196

Merged
merged 7 commits into from Oct 25, 2022

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Oct 24, 2022

  • Removing ipv6 pattern from regex_pattern_string_parameter_builder.py, which is currently only creating noise

Definition of Done

Please delete options that are not relevant.

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit e16a080
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63577733a90b780009e541d2
😎 Deploy Preview https://deploy-preview-6196--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Oct 24, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Shinnnyshinshin Shinnnyshinshin self-assigned this Oct 24, 2022
Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided all checks in Azure pass. Thank you!

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) October 24, 2022 18:39
@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) October 25, 2022 05:42
@Shinnnyshinshin Shinnnyshinshin merged commit 95e25e0 into develop Oct 25, 2022
@Shinnnyshinshin Shinnnyshinshin deleted the m/_/clean_up_regex_for_data_assistants branch October 25, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants