Refactor/data asset shouldnt need mutable evaluation parameters #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value from get_parameters_in_evaluation_parameter_store_by_run_id
abegong
changed the base branch from
v0.8.0_prep
to
refactor/convert_evaluation_parameter_to_store
jcampbell
reviewed
Aug 20, 2019
| @@ -1082,43 +1082,12 @@ def get_parameters_in_evaluation_parameter_store_by_run_id(self, run_id): | |||
| None | |||
| """ | |||
| if self.evaluation_parameter_store.has_key(run_id): | |||
| return self.evaluation_parameter_store.get(run_id) | |||
| return copy.deepcopy( | |||
There was a problem hiding this comment.
Not sure, tbh.
I know I misread the way binding worked, but without this copy, the potential to do the same thing is still there. I think we're better off keeping it, just in case. Not deeply committed to that opinion, though...
jcampbell
approved these changes
Aug 20, 2019
abegong
deleted the
refactor/data_asset_shouldnt_need_mutable_evaluation_parameters
branch
abegong
added a commit
that referenced
this pull request
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind_evaluation_parametersfunction.get_parameters_in_evaluation_parameter_store_by_run_idso that it's not mutable.I think I misread the DataAsset code earlier. That makes this a simple deletion instead of a real refactor.
This PR should be reviewed and merged after #633.