Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Use requirements.txt file when installing linting/static check dependencies in CI #6368

Merged
merged 8 commits into from Nov 15, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Nov 15, 2022

Changes proposed in this pull request:

  • Use pinned requirements in CI (instead of always pulling the latest).
    • Our CI should reflect our local environments - if we have a pin in our requirements, let's use that.

Definition of Done

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 21c253d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6373fb50eaa9040009b66e9a
😎 Deploy Preview https://deploy-preview-6368--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Nov 15, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@cdkini cdkini self-assigned this Nov 15, 2022
@cdkini cdkini changed the title [BUGFIX] Use requirements.txt file when installing linting dependencies in CI [BUGFIX] Use requirements.txt file when installing linting/static check dependencies in CI Nov 15, 2022
@cdkini cdkini requested a review from a team November 15, 2022 20:52
Copy link
Member

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@cdkini cdkini enabled auto-merge (squash) November 15, 2022 20:53
@anthonyburdi anthonyburdi merged commit 0759846 into develop Nov 15, 2022
@anthonyburdi anthonyburdi deleted the b/_/ensure_ci_utilizes_reqs_for_linting branch November 15, 2022 21:11
Shinnnyshinshin pushed a commit that referenced this pull request Nov 17, 2022
…ectations/great_expectations into f/dx-67/sql-pk-feature

* 'f/dx-67/sql-pk-feature' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] Cleanup Metrics and ExecutionEngine methods (#6371)
  [MAINTENANCE] Rename `GeCloudStoreBackend` to `GXCloudStoreBackend` (#6377)
  [MAINTENANCE] Make `ConfigurationProvider` and `ConfigurationSubstitutor` private (#6375)
  [MAINTENANCE] minor metrics typing (#6374)
  [BUGFIX] Patch nested snippet indentation issues within `remark-named-snippets` plugin (#6376)
  Removes comment in code that was causing confusion to some users. (#6366)
  [FEATURE] POC ZEP Config Loading (#6320)
  [MAINTENANCE] Move config variable substitution logic into `ConfigurationProvider` (#6345)
  [MAINTENANCE] Bump version of `black` in contrib CLI (#6370)
  [BUGFIX] Use `requirements.txt` file when installing linting/static check dependencies in CI (#6368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants