Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support to include ID/PK in validation result for each row - SQL #6448

Merged
merged 56 commits into from
Dec 5, 2022
Merged

[FEATURE] Support to include ID/PK in validation result for each row - SQL #6448

merged 56 commits into from
Dec 5, 2022

Commits on Nov 17, 2022

  1. Before the fix

    Will Shin committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    017350c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into b/dx-67/bugfix-metrics-return-empty-value

    William Shin committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    2af5d8d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. cleaned up db references

    Will Shin committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    43d30ac View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into b/dx-67/bugfix-metrics-return-empty-value

    William Shin committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0c93b5d View commit details
    Browse the repository at this point in the history

  3. bugfix

    Will Shin committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    015b84f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'b/dx-67/bugfix-metrics-return-empty-value' of https://g… 

    …ithub.com/great-expectations/great_expectations into b/dx-67/bugfix-metrics-return-empty-value

* 'b/dx-67/bugfix-metrics-return-empty-value' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] Migrate additional methods from `BaseDataContext` to other parts of context hierarchy (#6388)
  [MAINTENANCE] move `zep` -> `experimental` package (#6378)
    Will Shin committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    65c3e3a View commit details
    Browse the repository at this point in the history

  5. updated etst to not include extra comments or output

    Will Shin committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    61867c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Update test_map_metric.py

    Will Shin committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c2043bd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into b/dx-67/bugfix-metrics-return-empty-value 

    * develop: (22 commits)
  [BUGFIX] issue-4295-fix-issue (#6164)
  [DOCS] add boto3 explanations on document (#6407)
  [FEATURE] add multiple column metric (#6372)
  [MAINTENANCE] Small refactor (#6422)
  [MAINTENANCE] Sorting batch IDs and typehints clean up (#6421)
  [MAINTENANCE] Clean Up Type Hints and Minor Refactoring For Better Code Elegance/Readability (#6418)
  [MAINTENANCE] Implement `RendererConfiguration` (#6412)
  [BUGFIX] updated capitalone setup.py file (#6410)
  [FEATURE]: DataProfilerUnstructuredDataAssistant Integration (#6400)
  [FEATURE] add new metric - query template values (#5994)
  [MAINTENANCE] Cleanup For Better Code Elegance/Readability (#6406)
  [MAINTENANCE] ZEP - `GxConfig` cleanup (#6404)
  [MAINTENANCE] Migrate remaining methods from `BaseDataContext` (#6403)
  [BUGFIX] Patch key-generation issue with `DataContext.save_profiler()` (#6405)
  [MAINTENANCE] Migrate additional CRUD methods from `BaseDataContext` to `AbstractDataContext` (#6395)
  [MAINTENANCE] ZEP add yaml methods to all experimental models (#6401)
  [FEATURE] ZEP Config serialize as YAML (#6398)
  [MAINTENANCE] Remove call to verify_library_dependent_modules for pybigquery (#6394)
  [MAINTENANCE] Make "IDDict.to_id()" serialization more efficient. (#6389)
  [RELEASE] 0.15.34 (#6397)
  ...
    Will Shin committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c06b838 View commit details
    Browse the repository at this point in the history

  3. Update test_map_metric.py

    Will Shin committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    583f89d View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Update test_map_metric.py

    Will Shin committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    93ae465 View commit details
    Browse the repository at this point in the history

  2. update column names

    Will Shin committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    3b983a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into b/dx-67/bugfix-metrics-return-empty-value

    William Shin committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    712d9e2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into b/dx-67/bugfix-metrics-return-empty-value

    William Shin committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    cb54172 View commit details
    Browse the repository at this point in the history

  5. oops

    Will Shin committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    7dd34c3 View commit details
    Browse the repository at this point in the history

  6. Sql Metrics added from other PR

    Will Shin committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    75cc9b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge branch 'develop' into b/dx-67/sql-pk-id-metric 

    * develop:
  [MAINTENANCE] Additional `sqlite` database fixture for `taxi_data` - All 2020 data in single table (#6455)
  [BUGFIX] Metrics return value no longer returns None for `unexpected_index_list` - Sql and Spark (#6392)
  [DOCS] add configuration of anonymous_usage_statistics for documentati… (#6293)
  [BUGFIX] Fix for `mssql` tests that depend on `datetime` to `string` conversion (#6449)
  [FEATURE] add multiple input metric (#6373)
  [CONTRIB] add expectation - check gaps in SCD tables (#6433)
  [CONTRIB] Add no days missing expectation (#6432)
  [CONTRIB] Feature/add two tables expectation (#6429)
  [CONTRIB] Add number of unique values expectation (#6425)
  [MAINTENANCE] Clean Up Variable Names In Test Modules, Type Hints, and Minor Refactoring For Better Code Elegance/Readability (#6444)
    Will Shin committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    5a3b22f View commit details
    Browse the repository at this point in the history

  2. Update test_map_metric.py

    Will Shin committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    f5d1a05 View commit details
    Browse the repository at this point in the history

  3. see if this works for now

    Will Shin committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    6ab5d3e View commit details
    Browse the repository at this point in the history

  4. push before final check

    Will Shin committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    1cfc4df View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. fixed

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    9bfdde1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into b/dx-67/sql-pk-id-metric

    William Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2447162 View commit details
    Browse the repository at this point in the history

  3. cleaned up

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    5a11c0e View commit details
    Browse the repository at this point in the history

  4. cleaned up final function

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    75134e9 View commit details
    Browse the repository at this point in the history

  5. very large

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    7f03f3d View commit details
    Browse the repository at this point in the history

  6. final clean up

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    c4c78c7 View commit details
    Browse the repository at this point in the history

  7. make it shorter

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    1c4d0b9 View commit details
    Browse the repository at this point in the history

  8. Update map_metric_provider.py

    Will Shin committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    4b18bc7 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. simplifying the filtering

    Will Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ab9be1f View commit details
    Browse the repository at this point in the history

  2. whoohoo

    Will Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    94e54a9 View commit details
    Browse the repository at this point in the history

  3. let's add some tests

    Will Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    a2c7fcb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into b/dx-67/sql-pk-id-metric

    William Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    5d9c923 View commit details
    Browse the repository at this point in the history

  5. Update test_metrics_util.py

    Will Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b8c06b1 View commit details
    Browse the repository at this point in the history

  6. Update map_metric_provider.py

    Will Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    145c806 View commit details
    Browse the repository at this point in the history

  7. Update test_metrics_util.py

    Will Shin committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1b1163f View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. last fix

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    1bf4bf8 View commit details
    Browse the repository at this point in the history

  2. AB testing

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f75ea66 View commit details
    Browse the repository at this point in the history

  3. final set

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a8a5997 View commit details
    Browse the repository at this point in the history

  4. much cleaner

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    1090b07 View commit details
    Browse the repository at this point in the history

  5. athena needs special treatment

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    159966f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into b/dx-67/sql-pk-id-metric

    William Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    97cf510 View commit details
    Browse the repository at this point in the history

  7. monkeypatch everything

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2783c04 View commit details
    Browse the repository at this point in the history

  8. Update test_metrics_util.py

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8ca9b3f View commit details
    Browse the repository at this point in the history

  9. wow what was that

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    47caaca View commit details
    Browse the repository at this point in the history

  10. ok so we here go again

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9e2c00d View commit details
    Browse the repository at this point in the history

  11. i think i finally haev it this time

    Will Shin committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    ed131f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Update metrics_test.db

    Will Shin committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    6deb72e View commit details
    Browse the repository at this point in the history

  2. Update test_metrics_util.py

    Will Shin committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    72494f9 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. now the tests are fixed

    Will Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    7d63cd2 View commit details
    Browse the repository at this point in the history

  2. q1

    Will Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    071cf19 View commit details
    Browse the repository at this point in the history

  3. clean up of tests

    Will Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    40cf1f6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into b/dx-67/sql-pk-id-metric

    William Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ba177f6 View commit details
    Browse the repository at this point in the history

  5. Revert "clean up of tests" 

    This reverts commit 40cf1f6.
    Will Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c5e9741 View commit details
    Browse the repository at this point in the history

  6. Revert "Revert "clean up of tests"" 

    This reverts commit c5e9741.
    Will Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2eb7aa9 View commit details
    Browse the repository at this point in the history

  7. updated after synchronous review

    Will Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2abc598 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into b/dx-67/sql-pk-id-metric

    William Shin committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    2fe0627 View commit details
    Browse the repository at this point in the history