[MAINTENANCE] mypy config update
#6589
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,10 +25,24 @@ ignore_missing_imports = true | |
| follow_imports = 'silent' | ||
| warn_redundant_casts = true | ||
| show_error_codes = true | ||
| enable_error_code = [ | ||
| 'ignore-without-code' | ||
| ] | ||
| # The following list of codes are globally ignored, do not add to this list | ||
| disable_error_code = [ | ||
| # annotation-unchecked are 'warning notes', not errors and won't cause mypy to fail | ||
| # but it does create a lot of noise in the CI mypy step. | ||
| # https://mypy-lang.blogspot.com/2022/11/mypy-0990-released.html | ||
| 'annotation-unchecked' | ||
| ] | ||
| exclude = [ | ||
| # BEGIN ALWAYS EXCLUDE SECTION ##################################################### | ||
| # If pattern should always be excluded add comment explaining why and put | ||
| 'docs/', # Docs should not be type checked with the rest of the library. | ||
| '_version\.py', # generated by `versioneer` | ||
| 'v012', # legacy code | ||
| # END ALWAYS EXCLUDE SECTION ###################################################### | ||
| # | ||
| # ################################################################################# | ||
| # TODO: complete typing for the following modules and remove from exclude list | ||
| # number is the current number of typing errors for the excluded pattern | ||
|
|
@@ -70,7 +84,6 @@ exclude = [ | |
| 'core/usage_statistics/usage_statistics\.py', # 19 | ||
| 'core/usage_statistics/util\.py', # 2 | ||
| 'core/util\.py', # 18 | ||
|
There was a problem hiding this comment. @anthonyburdi |
||
| 'dataset/sparkdf_dataset\.py', # 3 | ||
| 'dataset/sqlalchemy_dataset\.py', # 16 | ||
| 'datasource/data_connector/configured_asset_sql_data_connector\.py', # 47 | ||
|
|
@@ -155,7 +168,6 @@ exclude = [ | |
| 'rule_based_profiler/parameter_builder/value_set_multi_batch_parameter_builder\.py', # 2 | ||
| 'rule_based_profiler/parameter_container\.py', # 7 | ||
| 'rule_based_profiler/rule_based_profiler\.py', # 40 | ||
|
There was a problem hiding this comment. @anthonyburdi why were we ignoring this file? We should opt to suppress the specific errors if they are unresolvable rather than ignore the whole file. |
||
| 'validation_operators/types/validation_operator_result\.py', # 35 | ||
| 'validation_operators/validation_operators\.py', # 16 | ||
| 'validator/exception_info\.py', # 1 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to call out that I am globally disabling this "error" code, which we should generally never do.
But in this case, this "error" code doesn't actually result in an error anyways, so it wouldn't actually prevent any bugs without an additional configuration setting like
check-untyped-defsSee the recent mypy release post section titled Warn about Variable Annotations in Unchecked Functions for these details.
If anyone has an issue with this let's discuss it.
Also, I initially turned on
check-untyped-defswith the idea that if the number of errors was low, I would just fix them but... I ended up getting about200new errors 😬 .I do think we should revisit this once we have better coverage of our existing "typed defs".