Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Enable more backends for some contrib expectations #6775

Merged
merged 11 commits into from Jan 12, 2023
Merged

[MAINTENANCE] Enable more backends for some contrib expectations #6775

merged 11 commits into from Jan 12, 2023

Conversation

kenwade4
Copy link
Contributor

@kenwade4 kenwade4 commented Jan 12, 2023 •
edited

Changes proposed in this pull request:

  • Enable more backends on several contrib Expectations
  • Remove the joegargery contributor from 3 non-example Expectations
  • Enable more backends for expect_queried_table_row_count_to_be
  • Remove remaining test_backends lists from contrib examples
  • Fix ValueError('All arrays must be of the same length') for to_be_valid_github_username
  • Fix ValueError('All arrays must be of the same length') for to_be_valid_iata_code
  • Update contrib Expectations to suppress any backend where all tests are failing

@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit d34b786
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63c06821c43f0a0008a66091
😎 Deploy Preview https://deploy-preview-6775--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jan 12, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

anthonyburdi
anthonyburdi approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kenwade4 kenwade4 enabled auto-merge (squash) January 12, 2023 20:05
@kenwade4 kenwade4 merged commit 95cf8da into develop Jan 12, 2023
@kenwade4 kenwade4 deleted the misc/enable-more-backends-for-some-expectations branch January 12, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyburdi anthonyburdi anthonyburdi approved these changes

Assignees
No one assigned
Labels
core-team dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenwade4 @anthonyburdi