Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the validation results to JSON serializable #6776

Conversation

lu-lz
Copy link
Contributor

@lu-lz lu-lz commented Jan 12, 2023

When configure include_unexpected_rows=true, the validation results will include all the columns of the unexpected rows. Some columns are date, datetime and decimal, they are not JSON serializable. This fix can successfully return the JSON serializable validation results.

When configure include_unexpected_rows=true, the validation results will include all the columns of the unexpected rows. Some columns are date, datetime and decimal, they are not JSON serializable. This fix can successfully return the JSON serializable validation results
@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit f6bf272
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63c092434325080009e7fcb5
😎 Deploy Preview https://deploy-preview-6776--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lu-lz
Copy link
Contributor Author

lu-lz commented Jan 12, 2023

@cla-bot check

@anthonyburdi anthonyburdi self-requested a review January 12, 2023 23:03
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

@anthonyburdi anthonyburdi enabled auto-merge (squash) January 12, 2023 23:05
@anthonyburdi anthonyburdi merged commit 3d5c571 into great-expectations:develop Jan 12, 2023
@Kilo59
Copy link
Member

Kilo59 commented Jan 23, 2023

Should fix #6357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants