Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Add exception message to RenderedAtomicContent failure renderer #6795

Merged
merged 19 commits into from Jan 24, 2023
Merged

[MAINTENANCE] Add exception message to RenderedAtomicContent failure renderer #6795

merged 19 commits into from Jan 24, 2023

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented Jan 13, 2023 •
edited

Changes proposed in this pull request:

  • GREAT-1590
  • Add exception to failed renderer payload for debugging by client

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 68d3438
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63cf3826f045f80008edc4eb
😎 Deploy Preview https://deploy-preview-6795--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jan 13, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@NathanFarmer NathanFarmer self-assigned this Jan 13, 2023
@NathanFarmer NathanFarmer marked this pull request as ready for review January 23, 2023 19:35
@NathanFarmer NathanFarmer requested review from billdirks and removed request for anthonyburdi January 23, 2023 21:47
Kilo59
Kilo59 reviewed Jan 23, 2023
View reviewed changes
great_expectations/render/components.py
@@ -742,11 +742,13 @@ def __init__(
name: Union[str, AtomicDiagnosticRendererType, AtomicPrescriptiveRendererType],
value: RenderedAtomicValue,
value_type: Optional[str] = None,
exception: Optional[str] = None,
Copy link
Member

@Kilo59 Kilo59 Jan 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this a str of? The class/exception name? The error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message. I'm not sure what class name you are referring to.

Kilo59
Kilo59 reviewed Jan 23, 2023
View reviewed changes
great_expectations/render/renderer/inline_renderer.py
Comment on lines +199 to +200
renderer_fn: Callable[
..., RenderedAtomicContent | RenderedContent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this gets reused a lot you could save this variable as a TypeAlias

RendererFn: TypeAlias =  Callable[..., RenderedAtomicContent | RenderedContent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't get reused often and I'd prefer to not declare this a type since the goal is to deprecate legacy RenderedContent.

Kilo59
Kilo59 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking questions.

@NathanFarmer
Make list a tuple
cd5f4ce
@NathanFarmer
Merge branch 'demo-renderer-configuration-errors' of github.com:great…
547064c 
…-expectations/great_expectations into demo-renderer-configuration-errors
@NathanFarmer NathanFarmer enabled auto-merge (squash) January 24, 2023 01:05
@NathanFarmer NathanFarmer merged commit 4187ec5 into develop Jan 24, 2023
@NathanFarmer NathanFarmer deleted the demo-renderer-configuration-errors branch January 24, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kilo59 Kilo59 Kilo59 approved these changes

@cdkini cdkini Awaiting requested review from cdkini

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky

@billdirks billdirks Awaiting requested review from billdirks

Assignees

@NathanFarmer NathanFarmer

Labels
core-team platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NathanFarmer @Kilo59