Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Clean up public_api excludes #6846

Merged
merged 3 commits into from Jan 20, 2023
Merged

[MAINTENANCE] Clean up public_api excludes #6846

merged 3 commits into from Jan 20, 2023

Conversation

anthonyburdi
Copy link
Member

Changes proposed in this pull request:

  • Remove checkpoint self_check from public API to be consistent with other excludes

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Jan 19, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 84f3410
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63c9ca694962de0008447305
😎 Deploy Preview https://deploy-preview-6846--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anthonyburdi anthonyburdi self-assigned this Jan 19, 2023
@anthonyburdi anthonyburdi requested review from Shinnnyshinshin and a team January 19, 2023 22:50
@anthonyburdi anthonyburdi enabled auto-merge (squash) January 19, 2023 22:51
Shinnnyshinshin
Shinnnyshinshin approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost
Copy link

ghost commented Jan 19, 2023

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@anthonyburdi anthonyburdi merged commit ce6f960 into develop Jan 20, 2023
@anthonyburdi anthonyburdi deleted the m/none/remove_self_check_from_checkpoint branch January 20, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees

@anthonyburdi anthonyburdi

Labels
core-team dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyburdi @Shinnnyshinshin