Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Typo - Update api_reference.md #7024

Merged
merged 2 commits into from Feb 1, 2023
Merged

Conversation

anthonyburdi
Copy link
Member

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], or [CONTRIB]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in GitHub issues or Slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@anthonyburdi anthonyburdi self-assigned this Feb 1, 2023
@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 8e7d34b
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63daddba1fbda30008b0a9df
😎 Deploy Preview https://deploy-preview-7024--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anthonyburdi anthonyburdi requested a review from a team February 1, 2023 21:43
@anthonyburdi anthonyburdi enabled auto-merge (squash) February 1, 2023 21:43
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost
Copy link

ghost commented Feb 1, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@anthonyburdi anthonyburdi merged commit a40a627 into develop Feb 1, 2023
@anthonyburdi anthonyburdi deleted the anthonyburdi-patch-1 branch February 1, 2023 21:50
Shinnnyshinshin pushed a commit that referenced this pull request Feb 1, 2023
…ate' into f/dx-244/dx-245/spark-id-pk-column-pair-map-metric

* f/dx-244/dx-246/pandas-id-pk-column-pair-map-metric-update:
  last bit of clean up
  much cleaner
  [DOCS] Typo - Update api_reference.md (#7024)
  [MAINTENANCE] ZEP - postgres test typing (#7023)
  [DOCS] Fix metric provider and reorganize sidebar (#7022)
  [FEATURE] Implement Experimental SparkDatasource with CSVDataAsset (#6981)
  [DOCS] DOC-416 How to use GX with AWS using Redshift (#6985)
  [BUGFIX] Patch logic error in new `add_or_update` methods (#7021)
  [MAINTENANCE] Make Pandas installation with Python 3.10 less restrictive (#7013)
  [DOCS] DOC-420 updates to screenshots (#7012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants