Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add API docs build to versioning instructions #7230

Merged
merged 3 commits into from Feb 24, 2023
Merged

[DOCS] Add API docs build to versioning instructions #7230

merged 3 commits into from Feb 24, 2023

Conversation

anthonyburdi
Copy link
Member

Changes proposed in this pull request:

  • Add API docs build instructions to docs versioning instructions

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run any local integration tests and made sure that nothing is broken.

@anthonyburdi anthonyburdi self-assigned this Feb 24, 2023
@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 778e10f
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63f945f2a6ea290008236c94
😎 Deploy Preview https://deploy-preview-7230--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anthonyburdi anthonyburdi requested a review from a team February 24, 2023 23:18
@anthonyburdi anthonyburdi enabled auto-merge (squash) February 24, 2023 23:19
@ghost
Copy link

ghost commented Feb 24, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Shinnnyshinshin
Shinnnyshinshin approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful :) thanks for adding. I tried the yarn commands from the /docusaurus folder and it works for me.

@anthonyburdi anthonyburdi merged commit 8bb246a into develop Feb 24, 2023
@anthonyburdi anthonyburdi deleted the d/dx-316/fix_versioning_instructions branch February 24, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees

@anthonyburdi anthonyburdi

Labels
core-team dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyburdi @Shinnnyshinshin