Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Optionally allow None values in RenderedAtomicContent #7240

Merged

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented Feb 27, 2023

Changes proposed in this pull request:

  • Optionally allow None values in RenderedAtomicContent
  • Call str on RendererValueType during serialization

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 02b2d5d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63fd3f0ffdf39600087307fe

@ghost
Copy link

ghost commented Feb 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@NathanFarmer NathanFarmer self-assigned this Feb 27, 2023
@dctalbot dctalbot self-requested a review February 27, 2023 16:12
NathanFarmer and others added 3 commits February 27, 2023 11:22
@NathanFarmer NathanFarmer marked this pull request as ready for review February 27, 2023 16:26
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Capturing the string output seems like be a good candidate for snapshot testing if you have that in place.

@NathanFarmer
Copy link
Contributor Author

Thanks! Capturing the string output seems like be a good candidate for snapshot testing if you have that in place.

What string output are you referring to? The rendered content can change, it is not static. Snapshots tests are probably the reason for the bugs in the first place, because if you take a snapshot of a bug, that doesn't make it no longer a bug.

@NathanFarmer NathanFarmer enabled auto-merge (squash) February 27, 2023 22:58
@NathanFarmer NathanFarmer merged commit 9ccda59 into develop Feb 28, 2023
@NathanFarmer NathanFarmer deleted the m/optionally-include-empty-rendered-content-values branch February 28, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants