-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Optionally allow None
values in RenderedAtomicContent
#7240
[MAINTENANCE] Optionally allow None
values in RenderedAtomicContent
#7240
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
…github.com:great-expectations/great_expectations into m/optionally-include-empty-rendered-content-values
… instead of marshmallow
…github.com:great-expectations/great_expectations into m/optionally-include-empty-rendered-content-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Capturing the string output seems like be a good candidate for snapshot testing if you have that in place.
What string output are you referring to? The rendered content can change, it is not static. Snapshots tests are probably the reason for the bugs in the first place, because if you take a snapshot of a bug, that doesn't make it no longer a bug. |
Changes proposed in this pull request:
None
values inRenderedAtomicContent
str
onRendererValueType
during serializationDefinition of Done