Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Correct a typographical error in specific path-forming template name for SparkDatasource-Microsoft Azure Blob Storage combination #7302

Conversation

alexsherstinsky
Copy link
Contributor

Scope

Fix typo in specific path-forming template name for SparkDatasource-Microsoft Azure Blob Storage combination.

Notes

Only integration or user-acceptance (UAT) test can exercise the functionality involved (specifically, UAT helped identify the issue).

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • JIRA: GREAT-1462/GREAT-1692/GREAT-1690/GREAT-1691/GREAT-1619

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit f09e2b3
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6407b011b8915b000874f429

@ghost
Copy link

ghost commented Mar 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@alexsherstinsky alexsherstinsky changed the title typo [BUGFIX] Correct a typographical error in specific path-forming template name for SparkDatasource-Microsoft Azure Blob Storage combination Mar 7, 2023
@alexsherstinsky alexsherstinsky marked this pull request as ready for review March 7, 2023 21:19
@alexsherstinsky alexsherstinsky enabled auto-merge (squash) March 7, 2023 21:19
…1/GREAT-1619/alexsherstinsky/zep/develop_data_connector_support_for_s3_gcs_abs_apply_to_pandas_datasource_spark_datasource-spark_filesystem_data_asset-2023_03_07-31
@alexsherstinsky alexsherstinsky merged commit 2c62a5e into develop Mar 7, 2023
@alexsherstinsky alexsherstinsky deleted the feature/GREAT-1462/GREAT-1692/GREAT-1690/GREAT-1691/GREAT-1619/alexsherstinsky/zep/develop_data_connector_support_for_s3_gcs_abs_apply_to_pandas_datasource_spark_datasource-spark_filesystem_data_asset-2023_03_07-31 branch March 7, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants