[BUGFIX] row_conditions now allow whitespace
#7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Shinnnyshinshin
commented
Mar 9, 2023
| column_name = Combine( | ||
| Suppress(Literal('col("')) | ||
| + Word(alphas, f"{alphanums}_.").setResultsName("column") | ||
| + Word(alphas, f"{alphanums}_-.").setResultsName("column") |
There was a problem hiding this comment.
allows for - to be used in column names, along with _
Shinnnyshinshin
commented
Mar 9, 2023
| @@ -56,7 +57,7 @@ def _set_notnull(s, l, t) -> None: # noqa: E741 # ambiguous name `l` | |||
| ops = (gt ^ lt ^ ge ^ le ^ eq ^ ne).setResultsName("op") | |||
| fnumber = Regex(r"[+-]?\d+(?:\.\d*)?(?:[eE][+-]?\d+)?").setResultsName("fnumber") | |||
| punctuation_without_apostrophe = punctuation.replace('"', "").replace("'", "") | |||
| condition_value_chars = alphanums + punctuation_without_apostrophe | |||
| condition_value_chars = alphanums + punctuation_without_apostrophe + SPACE_CHARS | |||
There was a problem hiding this comment.
adds SPACE_CHARS to valid condition_value_chars, which is turned into the condition value
Shinnnyshinshin
deleted the
b/dx-292/row-condition-should-allow-whitespace
branch
Shinnnyshinshin
commented
Mar 9, 2023
| @@ -42,9 +42,10 @@ def _set_notnull(s, l, t) -> None: # noqa: E741 # ambiguous name `l` | |||
| t["notnull"] = True | |||
|
|
|||
|
|
|||
| SPACE_CHARS = " " | |||
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
condition_value_charsinrow_conditions._and-can both appear in column names forrow_conditions.Definition of Done