New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] F/great 1463/add updates with datasource obj #7401
[FEATURE] F/great 1463/add updates with datasource obj #7401
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Before this PR is merged I need to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving but I do think that the stubs should be updated before merging.
As it could expose typing or issues with auto-completion.
Also non-blocking
but I think single-dispatch
might make this implementation simpler and reduce the number of conditionals.
https://github.com/great-expectations/great_expectations/pull/7401/files#r1143332512
Co-authored-by: Gabriel <gabriel59kg@gmail.com>
I've updated the stub files and renamed |
This allows one to use the datasource crud methods with either a datasource object or a set of constructor arguments. Previously only a set of constructor arguments was possible. This is useful because one way add assets or otherwise modify a datasource but that won't be saved to config until the user calls an update on the datasource.
The main complication I ran into was the previously allowed the
name
to be passed in as a positional or keyword argument. To maintain this or allow the datasource to be passed in positionally I had to do some extra validation to make sure the arguments were sensible.