[BUGFIX] Corrected typographical errors in two docstrings #7506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
kenwade4
approved these changes
Mar 29, 2023
alexsherstinsky
deleted the
feature/GREAT-761/GREAT-1285/DX-392/alexsherstinsky/rule_based_profiler/data_assistant/contrib/capital_one_data_profiler_column_domain_builder-2023_03_27-248
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Mar 29, 2023
…mitted_during_full_ci_run' into m/dx-372/engine_execute_warning_sqlalchemy_2 * origin/m/_/fix_warnings_that_are_only_emitted_during_full_ci_run: use optional imports, add note about pandas 2.0, general cleanup [MAINTENANCE] Pass `PandasDatasource` `batch_metadata` as `kwargs` to remove possibility of `None` on `DataAsset` model (#7503) [BUGFIX] Corrected typographical errors in two docstrings (#7506) [FEATURE] Introducing CapitalOne DataProfilerColumnDomainBuilder as well as multiple improvements to CapitalOne codebase and testability. (#7498) Lint Swallow sqlalchemy warning when using earlier pandas version [FEATURE] `BatchMetadata` for all fluent `DataAsset`s (#7392) Swallow sqlalchemy warning when using earlier pandas version
Shinnnyshinshin
pushed a commit
to richardohara/great_expectations
that referenced
this pull request
Mar 31, 2023
* develop: (137 commits) [RELEASE] 0.16.4 (great-expectations#7525) [MAINTENANCE] Remove airflow2 min depdency test. (great-expectations#7524) [MAINTENANCE] Dedicated airflow 2.2.0 async test (great-expectations#7518) [MAINTENANCE] Use YAMLHandler in tests and docs (great-expectations#7507) [MAINTENANCE] Revert PR 7490 (great-expectations#7515) [BUGFIX] Typo in min versions install (great-expectations#7516) [DOCS] corrects typo in GCS setup guide (great-expectations#7514) [DOCS] Testing ADR (great-expectations#7495) [MAINTENANCE] Bump numpy from 1.21.0 to 1.22.0 in /docs_rtd (great-expectations#7509) [MAINTENANCE] Bump nbconvert from 5.6.1 to 6.5.1 in /docs_rtd (great-expectations#7508) [MAINTENANCE] Bump jupyter-core from 4.6.3 to 4.11.2 in /docs_rtd (great-expectations#7496) [MAINTENANCE] Bump certifi from 2020.6.20 to 2022.12.7 in /docs_rtd (great-expectations#7497) [MAINTENANCE] Bump gitpython from 3.1.7 to 3.1.30 in /docs_rtd (great-expectations#7494) [MAINTENANCE] Fix sqlalchemy warnings for pandas + sql fluent datasources (great-expectations#7504) [MAINTENANCE] Make `dataset_name` a parameter for Expectations tests or create name from `Expectation` name, which ensures only limited number of tables created. (great-expectations#7476) [MAINTENANCE] Pass `PandasDatasource` `batch_metadata` as `kwargs` to remove possibility of `None` on `DataAsset` model (great-expectations#7503) [BUGFIX] Corrected typographical errors in two docstrings (great-expectations#7506) [FEATURE] Introducing CapitalOne DataProfilerColumnDomainBuilder as well as multiple improvements to CapitalOne codebase and testability. (great-expectations#7498) [FEATURE] `BatchMetadata` for all fluent `DataAsset`s (great-expectations#7392) [MAINTENANCE] Connection.connect warning for SQLAlchemy 2.0 compatibility (great-expectations#7489) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!