Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Patch broken include_rendered_content test in advance of 0.16.8 release #7663

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[BUGFIX] Patch broken include_rendered_content test in advance of 0.16.8 release #7663

merged 1 commit into from
Apr 20, 2023

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Apr 20, 2023

Changes proposed in this pull request:

  • This test broke as a result of changes made to enable fluent datasources
    • We simply needed to mock any new external calls made as a result of Store CRUD

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have run any local integration tests and made sure that nothing is broken.

@cdkini cdkini self-assigned this Apr 20, 2023
@netlify
Copy link

netlify bot commented Apr 20, 2023 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 0acaf7d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64415edb62605d00082e0e07

@github-actions github-actions bot added the core label Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@anthonyburdi anthonyburdi merged commit 5be30b7 into develop Apr 20, 2023
@anthonyburdi anthonyburdi deleted the b/lakitu-102/patch_rendered_content_test branch April 20, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kilo59 Kilo59 Kilo59 approved these changes

@NathanFarmer NathanFarmer Awaiting requested review from NathanFarmer

Assignees

@cdkini cdkini

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdkini @Kilo59 @anthonyburdi