Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update for fluent datasources: Create a new Checkpoint #7729

Merged
merged 10 commits into from Apr 26, 2023
Merged

[DOCS] Update for fluent datasources: Create a new Checkpoint #7729

merged 10 commits into from Apr 26, 2023

Conversation

anthonyburdi
Copy link
Member

Changes proposed in this pull request:

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@anthonyburdi anthonyburdi self-assigned this Apr 25, 2023
@netlify
Copy link

netlify bot commented Apr 25, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 31b7b56
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64492e0438779500095b6a16
😎 Deploy Preview https://deploy-preview-7729--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Apr 25, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@anthonyburdi anthonyburdi requested a review from a team April 25, 2023 19:52
alexsherstinsky
alexsherstinsky approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyburdi anthonyburdi enabled auto-merge (squash) April 26, 2023 13:58
@anthonyburdi anthonyburdi merged commit d006f0e into develop Apr 26, 2023
50 checks passed
@anthonyburdi anthonyburdi deleted the d/dx-441/create_a_new_checkpoint branch April 26, 2023 15:05
Shinnnyshinshin added a commit that referenced this pull request Apr 26, 2023
@Shinnnyshinshin
Merge branch 'develop' into m/_/deployment-pattern-gcp-bigquery
63cd759 
* develop:
  [MAINTENANCE] add warning messages when using CLI to edit an expectaiton suite if fluent datasources are present (#7714)
  [MAINTENANCE] fix get available data assets names for fds (#7723)
  [MAINTENANCE] Minor stylistic cleanup (#7732)
  [DOCS] Update for fluent datasources: Create a new Checkpoint (#7729)
  [MAINTENANCE] Iterate over the regex_pattern characters too in  (#7720)
  [MAINTENANCE] Add CLI warnings when adding a checkpoint with fluent datasources (#7685)
  [DOCS] Update batch glossary docs. (#7726)
  [BUGFIX] Add missing pyspark reference (#7684)
  [FEATURE] FDS persist `DataAsset` to YAML file immediately on creation  (#7705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsherstinsky alexsherstinsky alexsherstinsky approved these changes

Assignees

@anthonyburdi anthonyburdi

Labels
core dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyburdi @alexsherstinsky