Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Remove Prerequisites from Admonitions #7786

Merged
merged 13 commits into from
May 2, 2023
Merged

[DOCS] Remove Prerequisites from Admonitions #7786

merged 13 commits into from
May 2, 2023

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented May 1, 2023 •
edited
Loading

See the originating issue: DOC-188

Changes proposed in this pull request:

  • Remove prerequisite information from Admonitions
  • Make prerequisite lists parallel
  • Remove A passion for data quality as a prerequisite

@Rachel-Reverie please make any additional changes you think are necessary.

Definition of Done

  • I have made corresponding changes to the documentation
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented May 1, 2023 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit e5a2fec
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/645167b91cbbd10007d6f116
😎 Deploy Preview https://deploy-preview-7786--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label May 1, 2023
@ghost
Copy link

ghost commented May 1, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Rachel-Reverie
Rachel-Reverie approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwcanuck kwcanuck merged commit 0fd0d2c into develop May 2, 2023
@kwcanuck kwcanuck deleted the prerequisites-standardization- branch May 2, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachel-Reverie Rachel-Reverie Rachel-Reverie approved these changes

@joshzzheng joshzzheng Awaiting requested review from joshzzheng

Assignees
No one assigned
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwcanuck @Rachel-Reverie