[BUGFIX] fix add_or_update_expectation_suite update path
#7911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
NathanFarmer
requested changes
May 17, 2023
great_expectations/data_context/data_context/abstract_data_context.py
Outdated
Show resolved
Hide resolved
|
The updated tests should be sufficient for preventing regressions here |
NathanFarmer
approved these changes
May 22, 2023
Shinnnyshinshin
added a commit
that referenced
this pull request
May 23, 2023
…-expectations/great_expectations into m/_/credentials-doc-update * 'm/_/credentials-doc-update' of https://github.com/great-expectations/great_expectations: [BUGFIX] Setting maximum on `typing-extension` package version (#7970) [BUGFIX] Change GXSqlDialect.AWSATHENA to awsathena (#7950) [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/cloud/how_to_connect_to_data_on_gcs_using_spark" (#7964) [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/cloud/how_to_connect_to_data_on_gcs_using_pandas" (#7959) [DOCS] Add small doc change (#7957) [MAINTENANCE] Fix docs deploy (#7958) [MAINTENANCE] ignore black formatting and ruff auto-fix revisions (#7953) [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/database/how_to_connect_to_sqlite_data" (#7947) [BUGFIX] Cloud - fix `add_or_update_*()` when using `name` as keyword arg (#7952) [MAINTENANCE] black `23.3` (#7946) [BUGFIX] fix `add_or_update_expectation_suite` update path (#7911) [BUGFIX] Return qualified name when calling `TableAsset.as_selectable()` (#7942) [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/cloud/how_to_connect_to_data_on_s3_using_spark" (#7943) [MAINTENANCE] Update ruff to `0.0.269` and target `python 3.8` (#7945) [MAINTENANCE] bump python minimum version to 3.8 (#7916)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in which sequential calls to
ctx.add_or_update_expectation_suite(expectation_suite_name="foo")would result in an exception (it should be idempotent).The bug was as follows: GX Cloud requires the Expectation Suite's Cloud ID in order to request a PUT. This ID was not being set properly in the
add_or_update_expectation_suitemethod.Code is linted
Appropriate tests and docs have been updated