[FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/filesystem/how_to_connect_to_one_or_more_files_using_spark" #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22
…a_assets/how_to_organize_batches_in_a_file_based_data_asset.md Good suggestion -- comitted. Co-authored-by: T Pham <2117313+TrangPham@users.noreply.github.com>
…p_filesystem_data_asset_if_batching_regex_matches_multiple_files.md Thanks for catching the typo. Co-authored-by: T Pham <2117313+TrangPham@users.noreply.github.com>
…p_filesystem_data_asset_if_batching_regex_matches_multiple_files.md Thanks! Co-authored-by: T Pham <2117313+TrangPham@users.noreply.github.com>
…stinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22' into feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22
…ocuments_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22' into feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…ocuments_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-22' into feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…a_assets/how_to_organize_batches_in_a_sql_based_data_asset.md Co-authored-by: T Pham <2117313+TrangPham@users.noreply.github.com>
Co-authored-by: T Pham <2117313+TrangPham@users.noreply.github.com>
Co-authored-by: T Pham <2117313+TrangPham@users.noreply.github.com>
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_16-23
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
alexsherstinsky
force-pushed
the
feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
branch
from
1c919a5
to
33ace8a
Compare
added 2 commits
May 18, 2023 10:17
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
alexsherstinsky
force-pushed
the
feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
branch
from
1d674ad
to
e5d0da1
Compare
Shinnnyshinshin
requested changes
May 18, 2023
There was a problem hiding this comment.
Thank you @alexsherstinsky, some requested changes around methods added to the @public_api
added 2 commits
May 18, 2023 12:42
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
alexsherstinsky
force-pushed
the
feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
branch
from
bad4167
to
6d79f2d
Compare
added 2 commits
May 18, 2023 13:41
…k/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
alexsherstinsky
force-pushed
the
feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
branch
from
a44d278
to
d8763e5
Compare
Shinnnyshinshin
approved these changes
May 18, 2023
Shinnnyshinshin
approved these changes
May 18, 2023
billdirks
reviewed
May 18, 2023
There was a problem hiding this comment.
Thanks for doing this @alexsherstinsky. One small grammatical comment and a comment about using a deprecation decorator instead of inlining in the docstring.
| Convenience method to run "table.head" metric. | ||
| """Convenience method to return the first several rows or records from a Batch of data. | ||
|
|
||
| (To be deprecated in favor of using methods in "MetricsCalculator" class.) |
There was a problem hiding this comment.
I think we have an @deprecated_method_or_class decorator to mark things as deprecated. I haven't used it but you can find examples in the code or ask @anthonyburdi. Using it will mark it as deprecated in our published docs.
...connecting_to_your_data/fluent/filesystem/how_to_connect_to_one_or_more_files_using_spark.md
Outdated
Show resolved
Hide resolved
…esystem/how_to_connect_to_one_or_more_files_using_spark.md Thanks you! Co-authored-by: Bill Dirks <bill@greatexpectations.io>
…stinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25' into feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
billdirks
approved these changes
May 18, 2023
There was a problem hiding this comment.
LGTM.
There is 1 deprecated docstring left that needs to be removed: https://github.com/great-expectations/great_expectations/pull/7927/files#diff-c0dc20209b0c340812ba02fcc9774b23c116256e45c13de7769a26ad8210b4d9R82
billdirks
approved these changes
May 18, 2023
There was a problem hiding this comment.
LGTM.
There is 1 deprecated docstring left that needs to be removed: https://github.com/great-expectations/great_expectations/pull/7927/files#diff-c0dc20209b0c340812ba02fcc9774b23c116256e45c13de7769a26ad8210b4d9R82
Done -- thanks for catching it (it was a typo). |
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
alexsherstinsky
deleted the
feature/DX-469/DX-441/alexsherstinsky/link/docusaurus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_17-25
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Remarks
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted
Appropriate tests and docs have been updated
For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!