-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/cloud/how_to_connect_to_data_on_s3_using_pandas" #7941
[FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/cloud/how_to_connect_to_data_on_s3_using_pandas" #7941
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
…rus_documents_should_use_python_code_script_tags_referring_to_integration_tests-2023_05_19-29
|
||
assert datasource_name in context.datasources | ||
|
||
# Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does commenting python here add syntax highlighting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TrangPham Good question -- I am not sure. It may not be necessary, because in the document, there is a "python" tag. However, this has been the style I inherited from others' examples and found it to be aesthetically nice. Maybe we can try locally using invoke docs
and see whether or not it adds anything to the HTML view. Thanks.
@@ -54,10 +48,11 @@ def aws_credentials() -> None: | |||
os.environ["AWS_SESSION_TOKEN"] = "testing" | |||
|
|||
|
|||
@pytest.mark.skipif(not aws.boto3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Scope
Remarks
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted
Appropriate tests and docs have been updated
For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!