Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update prefect gx tutorial #8009

Merged
merged 12 commits into from Jun 11, 2023

Conversation

discdiver
Copy link
Contributor

@discdiver discdiver commented May 25, 2023

Updates Prefect tutorial for Prefect 2.

  • Description of PR changes above includes a link to an existing GitHub issue

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]

  • Code is linted

    black .
    
    ruff . --fix
    
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Closes #8085

@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 6eb9376
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6485c31060e2120008c2c75b
😎 Deploy Preview https://deploy-preview-8009--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@discdiver discdiver changed the title DOCS Update prefect gx tutorial [DOCS] Update prefect gx tutorial May 26, 2023
Copy link
Contributor

@kenwade4 kenwade4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating this tutorial @discdiver! I just have some minor change requests, then it should be good to merge.

@discdiver
Copy link
Contributor Author

Thank you, @kenwade4! All changes made. Please let me know if you need anything else from me.

@discdiver discdiver requested a review from kenwade4 June 8, 2023 18:52
Copy link
Contributor

@kenwade4 kenwade4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates!

@kenwade4 kenwade4 merged commit 5d4c952 into great-expectations:develop Jun 11, 2023
43 checks passed
TrangPham pushed a commit that referenced this pull request Jun 12, 2023
@HaebichanGX
Copy link
Contributor

HaebichanGX commented Aug 2, 2023

Hi @discdiver, I'm Haebichan Jung from the DevRel team at GX. I've recently testing this code, and it seems like it's causing errors due to updates on our side. Specifically, we've deprecated the great_expectations init cli. We are now using FileDataContext object.

The code below needs to run after creating my_gx_project folder (in lieu of great_expectations folder that will be created from the init cli). As the current code doesn't work with current implementation of GX, would it be possible to have it updated?

from great_expectations.core.expectation_configuration import ExpectationConfiguration
import pandas as pd
import os 
from great_expectations.data_context import FileDataContext

base = os.getcwd()

path_to_empty_folder = base + "/my_gx_project/"

context = FileDataContext.create(project_root_dir=path_to_empty_folder)```

@discdiver
Copy link
Contributor Author

discdiver commented Aug 7, 2023

Hi Haebichan Jung. Thank you. If you have working code, do you want to make the PR to your repo and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Prefect tutorial
5 participants