[MAINTENANCE] Update default action list in Checkpoint based on user environment
#8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
Jun 6, 2023
| @@ -2118,6 +2118,8 @@ def _resolve_add_checkpoint_args( # noqa: PLR0913 | |||
| "Must either pass in an existing checkpoint or individual constructor arguments (but not both)" | |||
| ) | |||
|
|
|||
| action_list = action_list or self._determine_default_action_list() | |||
There was a problem hiding this comment.
I'd love to push this down into the Checkpoint but that would require an isinstance(context, CloudDataContext). Thoughts? Feels a little bad here.
There was a problem hiding this comment.
Perhaps another selling point for CloudCheckpoint?
…_expectations into m/lakitu-190/update_default_action_list
Kilo59
approved these changes
Jun 6, 2023
…_expectations into m/lakitu-190/update_default_action_list
…hub.com/great-expectations/great_expectations into m/lakitu-190/update_default_action_list
Shinnnyshinshin
added a commit
that referenced
this pull request
Jun 7, 2023
…ons/great_expectations into m/_/pandas2-only * 'm/_/pandas2-only' of https://github.com/great-expectations/great_expectations: [MAINTENANCE] Add public_api to read_parquet (#8060) [BUGFIX] fix issue-7954 (#7963) [MAINTENANCE] Delete `LegacyCheckpoint` (#8082) [BUGFIX] Fix broken Cloud tests around `Checkpoint` (#8083) [MAINTENANCE] Update PR template to reference `invoke` for linting (#8079) [MAINTENANCE] Ruff `0.0.271` update (#8077) [MAINTENANCE] Update default action list in `Checkpoint` based on user environment (#8074)
TrangPham
pushed a commit
that referenced
this pull request
Jun 12, 2023
…r environment (#8074) Co-authored-by: Rob Lim <robert.m.lim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud contexts should not have reference to
UpdateDataDocsDescription of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted
Appropriate tests and docs have been updated
For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!