[MAINTENANCE] Type hint cleanup in usage statistics #8105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Kilo59
reviewed
Jun 13, 2023
Comment on lines
+230
to
+233
| func: Callable | None = None, | ||
| event_name: UsageStatsEvents | None = None, | ||
| args_payload_fn: Callable | None = None, | ||
| result_payload_fn: Callable | None = None, |
There was a problem hiding this comment.
Is there anything else about the callable that we can declare here?
Like what they are expected to return or the params they accept?
There was a problem hiding this comment.
unfortunately its a super variable input list (the fn in question here is any method we decorate)
There was a problem hiding this comment.
if you look at the context, we have a number of varied usage stats decorated methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesblack+ruff)For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!