[MAINTENANCE] Use Available Enums Instead of Strings for Metric Name Extensions #8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
…ule_based_profiler/data_assistant/use_defined_enum_values_for_metric_name_extensions-2023_06_16-300
alexsherstinsky
changed the title
TrangPham
reviewed
Jun 16, 2023
| @@ -3148,6 +3148,9 @@ def _plot_table_domain_charts( # noqa: PLR0913 | |||
| Domain, Dict[str, List[ParameterNode]] | |||
| ] = self._determine_attributed_metrics_by_domain_type(MetricDomainTypes.TABLE) | |||
|
|
|||
| if not attributed_metrics_by_table_domain: | |||
There was a problem hiding this comment.
This seems like functionality change. Is there a test for this code path?
There was a problem hiding this comment.
Deleted and created a new ticket concerning this issue. Thanks!
TrangPham
approved these changes
Jun 16, 2023
alexsherstinsky
deleted the
maintenance/DX-594/alexsherstinsky/link/rule_based_profiler/data_assistant/use_defined_enum_values_for_metric_name_extensions-2023_06_16-300
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
We have adopted
Enumstructures for Metric Names -- they should be used codebase-wide.Remarks
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted
Appropriate tests and docs have been updated
For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!