Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix 'great_expectations[cloud]' extra install #8151

Merged
merged 2 commits into from Jun 21, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Jun 21, 2023

Logic in setup.py was adding and then removing a cloud "extra" when creating the tests "extra".

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@github-actions github-actions bot added the core label Jun 21, 2023
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 222abfd
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6492fe69bee2d7000796521e

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 32b2557
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6492fe70c3b8ec0008d55f6e

@ghost
Copy link

ghost commented Jun 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 marked this pull request as ready for review June 21, 2023 13:44
@Kilo59 Kilo59 self-assigned this Jun 21, 2023
@Kilo59 Kilo59 changed the title [BUGFIX] Fix 'greate_expectations[cloud]' extra install [BUGFIX] Fix 'great_expectations[cloud]' extra install Jun 21, 2023
@Kilo59 Kilo59 enabled auto-merge (squash) June 21, 2023 14:17
@Kilo59 Kilo59 requested review from cdkini, anthonyburdi and DrewHoo and removed request for anthonyburdi and cdkini June 21, 2023 14:17
@Kilo59 Kilo59 merged commit 12d50ce into develop Jun 21, 2023
54 checks passed
@Kilo59 Kilo59 deleted the b/_/fix-cloud-extras branch June 21, 2023 14:43
Shinnnyshinshin added a commit that referenced this pull request Jun 21, 2023
…ps://github.com/great-expectations/great_expectations into f/dx-289/dx-223/snowflake-reference-environment

* 'f/dx-289/dx-223/snowflake-reference-environment' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] Add --bash command for postgres reference env (#8154)
  [BUGFIX] Fix 'great_expectations[cloud]' extra install (#8151)
  [DOCS] Fix broken links and reenable link checking (#8146)
  [CONTRIB] expect_queried_column_pair_values_to_be_both_filled_or_null (#7949)
  [MAINTENANCE] Update single cloud onboarding script to use fluent datasources (#8114)
  [BUGFIX] Fix config substitution for substrings (#8145)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants