Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fix azure docs tests #8171

Merged
merged 4 commits into from Jun 27, 2023
Merged

Conversation

TrangPham
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit b36f5e2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/649b321bc797e60008bb9ac3

@github-actions github-actions bot added the core label Jun 22, 2023
@ghost
Copy link

ghost commented Jun 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@TrangPham TrangPham marked this pull request as ready for review June 26, 2023 19:52
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TrangPham TrangPham enabled auto-merge (squash) June 27, 2023 18:47
@TrangPham TrangPham merged commit e5c83f6 into develop Jun 27, 2023
62 checks passed
@TrangPham TrangPham deleted the DX-583-fix-final-2-azure-docs-tests branch June 27, 2023 20:19
Shinnnyshinshin added a commit that referenced this pull request Jun 27, 2023
* develop:
  [FEATURE] Reference Environment - BigQuery (#8176)
  [FEATURE] Fix azure docs tests (#8171)
  [DOCS] Getting Started with GX (#8143)
  [MAINTENANCE] Replace Non-Existent Expectation Name With Correct Existing Expectation Name (#8191)
  [MAINTENANCE] Start cleaning up outdated deprecation warnings (#8135)
  [MAINTENANCE] Fix Python 3.11 Docker excessive pip backtracking (#8187)
  [MAINTENANCE] Rich comments and docstrings for DataAssistant related modules. (#8185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants