Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Fix Python 3.11 async expectations tests #8203

Merged
merged 16 commits into from Jun 29, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Jun 28, 2023

This PR overwites the Maturity enum .__format__ method to presevere the backwards compatibility

The following tests fail in the Async Test pipeline due to changes in how Enums are represented as strings in formated strings in Python 3.11.
Updated the tests to remove the hard-coded enum representation.

https://docs.python.org/3/whatsnew/3.11.html#enum

FAILED tests/expectations/test_generate_diagnostic_checklist.py::test_print_diagnostic_checklist__second_iteration
FAILED tests/expectations/test_generate_diagnostic_checklist.py::test_print_diagnostic_checklist__third_iteration
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 8398a2a
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/649d50ae331aee0008a8f4c9

@github-actions github-actions bot added the core label Jun 28, 2023
@Kilo59 Kilo59 self-assigned this Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 changed the title [MAINTENANCE] Maturity.__format__ for Python 3.11 backwards compatiblity [MAINTENANCE] Fix Python 3.11 async expectations tests Jun 28, 2023
@Kilo59 Kilo59 marked this pull request as ready for review June 28, 2023 13:29
@Kilo59 Kilo59 enabled auto-merge (squash) June 28, 2023 13:42
@Kilo59 Kilo59 requested a review from billdirks June 28, 2023 13:54
@Kilo59 Kilo59 merged commit e7d0921 into develop Jun 29, 2023
46 checks passed
@Kilo59 Kilo59 deleted the m/lakitu-251/fix-py311-async-tests branch June 29, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants