[MAINTENANCE] Placing AWS RedShift Imports Under Compatibility Pattern #8205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2023 09:44
…ink/update_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
✅ Deploy Preview for niobium-lead-7998 canceled.
|
…ink/update_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
alexsherstinsky
changed the title
added 2 commits
June 28, 2023 11:54
…ink/update_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
TrangPham
reviewed
Jun 28, 2023
Comment on lines
261
to
262
| else: | ||
| pass |
There was a problem hiding this comment.
nit (non-blocking): I don't think the else pass is required
Suggested change
| else: | |
| pass |
There was a problem hiding this comment.
@TrangPham Great catch -- deleted. Thanks!
| try: | ||
| import sqlalchemy_redshift | ||
| except ImportError: | ||
| sqlalchemy_redshift = AWS_NOT_IMPORTED |
There was a problem hiding this comment.
I think within the same file is fine. Perhaps a different error message would be better as to not tell user to install something they may not require
Suggested change
| sqlalchemy_redshift = AWS_NOT_IMPORTED | |
| sqlalchemy_redshift = NotImported( | |
| "Redshift connection components are not installed, please 'pip install sqlalchemy_redshift'" | |
| ) |
There was a problem hiding this comment.
@TrangPham Different message created -- thanks!
alexsherstinsky
force-pushed
the
maintenance/DX-1/DX-440/alexsherstinsky/link/update_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
branch
from
126fa3c
to
a191d06
Compare
…e_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
alexsherstinsky
requested review from
TrangPham,
anthonyburdi and
Shinnnyshinshin
…e_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
TrangPham
approved these changes
Jun 28, 2023
alexsherstinsky
deleted the
maintenance/DX-1/DX-440/alexsherstinsky/link/update_not_imported_mechanism_to_use_scoped_compatibility_modules_instead-2023_06_28-50
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
sqlalchemy_redshift, they are placed under the established "Compatibility" coding pattern.Remarks
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted
Appropriate tests and docs have been updated
For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!