[MAINTENANCE] Placing BigQuery Imports Under Compatibility Pattern #8214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinnnyshinshin
commented
Jun 28, 2023
Comment on lines
24
to
28
| try: | ||
| from sqlalchemy_bigquery import parse_url | ||
| except (ImportError, AttributeError): | ||
| parse_url = SQLALCHEMY_BIGQUERY_NOT_IMPORTED | ||
|
|
There was a problem hiding this comment.
This was the only module that was missing. It was added to compatibility/bigquery.py
Shinnnyshinshin
commented
Jun 28, 2023
| from great_expectations.execution_engine import ( | ||
| SqlAlchemyExecutionEngine, # noqa: TCH001 | ||
| ) | ||
| from great_expectations.execution_engine.sqlalchemy_dialect import GXSqlDialect | ||
| from great_expectations.util import filter_properties_dict | ||
| from great_expectations.util import filter_properties_dict, get_sqlalchemy_inspector |
There was a problem hiding this comment.
Some additional linting was done here.
✅ Deploy Preview for niobium-lead-7998 canceled.
|
TrangPham
approved these changes
Jun 29, 2023
alexsherstinsky
approved these changes
Jun 29, 2023
added 2 commits
June 28, 2023 22:17
alexsherstinsky
force-pushed
the
m/dx-440/bigquery
branch
from
c7582c8
to
cc3c51a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigqueryunder Compatibility pattern.compatibility.sqlalchemy_bigqueryis renamed tocompatibility.bigqueryto be consistent with other backendsinvoke lint(usesblack+ruff)For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!