Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Update notebook link to non-legacy docs #8215

Merged
merged 5 commits into from Jun 29, 2023
Merged

[MAINTENANCE] Update notebook link to non-legacy docs #8215

merged 5 commits into from Jun 29, 2023

Conversation

donaldheppner
Copy link
Member

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

@github-actions github-actions bot added the core label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 28, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 36d73ef
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/649d12a1bb1b3a00088f0c21

Shinnnyshinshin
Shinnnyshinshin approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this @donaldheppner

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) June 29, 2023 04:39
@Shinnnyshinshin Shinnnyshinshin merged commit 4d13e12 into develop Jun 29, 2023
27 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the m/DX-74/update_links branch June 29, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@donaldheppner @Shinnnyshinshin