Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] View data docs inside snowflake and bigquery reference environments #8231

Merged
merged 9 commits into from Jun 30, 2023
Merged

[FEATURE] View data docs inside snowflake and bigquery reference environments #8231

merged 9 commits into from Jun 30, 2023

Conversation

anthonyburdi
Copy link
Member

@anthonyburdi anthonyburdi commented Jun 30, 2023 •
edited

  • This PR adds a separate container that serves data docs for easy viewing in the bigquery and snowflake reference environments.
  • It also fixes a few items for consistency and adds more description to a few readme files.

@netlify
Copy link

netlify bot commented Jun 30, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit fa7f5c4
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/649f50bd25ed280008367e12
😎 Deploy Preview https://deploy-preview-8231--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Jun 30, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@anthonyburdi anthonyburdi changed the title [FEATURE] View data docs inside ref envs other envs [FEATURE] View data docs inside reference environments Jun 30, 2023
@anthonyburdi anthonyburdi self-assigned this Jun 30, 2023
@anthonyburdi anthonyburdi marked this pull request as ready for review June 30, 2023 21:53
@anthonyburdi anthonyburdi requested a review from a team June 30, 2023 21:53
@anthonyburdi anthonyburdi changed the title [FEATURE] View data docs inside reference environments [FEATURE] View data docs inside snowflake and bigquery reference environments Jun 30, 2023
@anthonyburdi anthonyburdi enabled auto-merge (squash) June 30, 2023 21:54
Shinnnyshinshin
Shinnnyshinshin approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the synchronous review on this @anthonyburdi. LGTM!

@anthonyburdi anthonyburdi merged commit 005f809 into develop Jun 30, 2023
43 checks passed
@anthonyburdi anthonyburdi deleted the f/dx-608/view_data_docs_inside_ref_envs_other_envs branch June 30, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees

@anthonyburdi anthonyburdi

Labels
core dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyburdi @Shinnnyshinshin