Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Add data docs container to airflow env #8284

Merged

Conversation

anthonyburdi
Copy link
Member

Add a data docs container to the airflow environment for easy viewing of data docs.

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 9a6070b
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64aee25c1391e100088ea8de

@ghost
Copy link

ghost commented Jul 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@anthonyburdi anthonyburdi self-assigned this Jul 11, 2023
@anthonyburdi anthonyburdi requested a review from a team July 11, 2023 21:52
@@ -167,6 +169,17 @@ services:
airflow-init:
condition: service_completed_successfully

data_docs:
# airflow-common is added so that the volumes config is available to the data_docs container
<<: *airflow-common
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was new to me, these are YAML anchors: https://stackoverflow.com/a/45805673.

@anthonyburdi anthonyburdi enabled auto-merge (squash) July 11, 2023 21:53
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anthony I was getting the following error while running the containers locally. Could we pair on this before merging?

[2023-07-12, 00:20:19 UTC] {standard_task_runner.py:104} ERROR - Failed to execute job 10 for task validate_order_data_extract ([Errno 13] Permission denied: '/gx/gx_stores/data_docs/static'; 125)

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works! LGTM!

@anthonyburdi anthonyburdi enabled auto-merge (squash) July 12, 2023 16:41
@anthonyburdi anthonyburdi merged commit 91a281f into develop Jul 12, 2023
29 checks passed
@anthonyburdi anthonyburdi deleted the m/dx-289/dx-588/add_data_docs_container_to_airflow_env branch July 12, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants