Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Finish marking fluent datasource tests. #8347

Merged
merged 2 commits into from Jul 19, 2023

Conversation

billdirks
Copy link
Contributor

@billdirks billdirks commented Jul 18, 2023

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@github-actions github-actions bot added the core label Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 59dad70
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64b7226cf35155000807bd98

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) July 18, 2023 23:30
@Shinnnyshinshin Shinnnyshinshin merged commit c550394 into develop Jul 19, 2023
41 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the f/pp-255/mark-datasource-fluent-tests branch July 19, 2023 00:31
Shinnnyshinshin added a commit that referenced this pull request Jul 19, 2023
* develop: (68 commits)
  [MAINTENANCE] Making tests for column names insensitivity for Oracle, DB2, and Snowflake easier to read (#8358)
  [MAINTENANCE] Update standard node package (#8339)
  [MAINTENANCE] Re-mark slow tests. (#8356)
  [DOCS] Updated the Execution Engine terms page (#8309)
  [BUGFIX] Ensure that GX supports database column names in lowercase and mixcase for Oracle, DB2, and Snowflake (#8345)
  [MAINTENANCE] Add test markers to datasource/batch_kwarg_generator tests. (#8348)
  Bump word-wrap from 1.2.3 to 1.2.4 in /docs/docusaurus (#8346)
  [BUGFIX] Ensure that Fluent Datasources support database table names in lowercase for Oracle, DB2, and Snowflake (#8327)
  [MAINTENANCE] Finish marking fluent datasource tests. (#8347)
  [MAINTENANCE] Replace many repetitive slow integration tests for ParameterBuilder components with a few fast unit tests (#8302)
  [MAINTENANCE] Pytest Mark - DataConnector (#8338)
  [FEATURE] Register MissingnessDataAssistant (#8337)
  [DOCS] Adds a consolidated overview of using GX as a conceptual guide (#8045)
  [MAINTENANCE] Update algolia index (#8273)
  [CONTRIB] Create custom expectation for Chi Square Test (#8314)
  [DOCS] Update Slack Link to Point to Discourse (#7840)
  [MAINTENANCE] Bump minimum version of `numpy==1.21.6` for Python 3.9 (#8341)
  [MAINTENANCE] Disable Airflow provider tests in CI due to external test failures (#8342)
  [MAINTENANCE] Minimum version of `numpy` bumped to `1.20.3` (#8326)
  [MAINTENANCE] Pytest Mark - Integration and Expectations (#8319)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants