Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gcp #841

Merged
merged 17 commits into from
Nov 13, 2019
Merged

Feature/gcp #841

merged 17 commits into from
Nov 13, 2019

Conversation

williamjr
Copy link
Contributor

This draft PR adds limited support for Google Cloud Platform. It includes:

  • A Google Cloud Storage (GCS) store backend
  • SQLAlchemy backend support for BigQuery via pybigquery

Note that a GCS generator was out of scope for this PR, but should be implemented in a future release to achieve full parity between AWS and GCP.

@cla-bot
Copy link

cla-bot bot commented Oct 28, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@pep8speaks
Copy link

pep8speaks commented Oct 28, 2019

Thank you for submitting to Great Expectations!

Line 451:5: E303 too many blank lines (2)

Line 249:121: E501 line too long (146 > 120 characters)

Line 173:25: E128 continuation line under-indented for visual indent
Line 174:25: E128 continuation line under-indented for visual indent
Line 175:25: E128 continuation line under-indented for visual indent
Line 176:25: E124 closing bracket does not match visual indentation

Line 194:1: W293 blank line contains whitespace

Line 215:121: E501 line too long (136 > 120 characters)
Line 216:12: E127 continuation line over-indented for visual indent
Line 235:46: E261 at least two spaces before inline comment
Line 235:121: E501 line too long (126 > 120 characters)
Line 244:1: W293 blank line contains whitespace

This linter comment has been updated based on the most recent commit.

Comment last updated at 2019-11-06 15:56:30 UTC

Copy link
Member

@jcampbell jcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick questions...

great_expectations/data_context/store/store_backend.py Outdated Show resolved Hide resolved
tests/store/test_store_backends.py Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@coveralls
Copy link

coveralls commented Nov 5, 2019

Coverage Status

Coverage decreased (-0.05%) to 79.31% when pulling e68a246 on williamjr:feature/gcp into 282e7ca on great-expectations:develop.

@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

great_expectations/dataset/sqlalchemy_dataset.py Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
bucket,
prefix,
project,
forbidden_substrings=["/", "\\"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: harmonize this with the change for platform independent paths in #848

great_expectations/dataset/sqlalchemy_dataset.py Outdated Show resolved Hide resolved
Co-Authored-By: James Campbell <james.p.campbell@gmail.com>
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Co-Authored-By: James Campbell <james.p.campbell@gmail.com>
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Co-Authored-By: James Campbell <james.p.campbell@gmail.com>
@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 5, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

jcampbell
jcampbell previously approved these changes Nov 6, 2019
@cla-bot
Copy link

cla-bot bot commented Nov 6, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jcampbell
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 12, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 12, 2019

The cla-bot has been summoned, and re-checked this pull request!

@scarrucciu
Copy link
Contributor

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 12, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 12, 2019

The cla-bot has been summoned, and re-checked this pull request!

@jcampbell jcampbell merged commit 8bf50a0 into great-expectations:develop Nov 13, 2019
@jcampbell
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 13, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Spencer Carrucciu.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 13, 2019

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants