Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update contributing code readme with required markers information. #8414

Merged
merged 5 commits into from Jul 26, 2023

Conversation

billdirks
Copy link
Contributor

@billdirks billdirks commented Jul 25, 2023

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@billdirks billdirks requested a review from kwcanuck July 25, 2023 21:17
@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit b70e0c2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64c13f18e98a4f0008997700

@github-actions github-actions bot added the core label Jul 25, 2023
@ghost
Copy link

ghost commented Jul 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING_CODE.md Outdated Show resolved Hide resolved
CONTRIBUTING_CODE.md Outdated Show resolved Hide resolved
CONTRIBUTING_CODE.md Outdated Show resolved Hide resolved
billdirks and others added 2 commits July 26, 2023 08:43
Co-authored-by: Rob Gray <104205257+kwcanuck@users.noreply.github.com>
@billdirks billdirks enabled auto-merge (squash) July 26, 2023 15:43
@billdirks billdirks merged commit a830133 into develop Jul 26, 2023
37 checks passed
@billdirks billdirks deleted the m/pp-254/update-contrib-docs-for-test-markers branch July 26, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants