New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Removed sqlalchemy_version_compatibility from required test markers. #8456
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
# Despite being parameterized over GXSqlDialect, this test skips if the flag corresponding to that dialect isn't | ||
# passed in. Most of these dialects are never run in CI. | ||
# TODO: remove the external_sqldialect and uncomment the all_backends mark once all_backends is supported. | ||
# @pytest.mark.all_backends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the helpful note here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've re-added the |
invoke lint
(usesblack
+ruff
)For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!