[MAINTENANCE] Remove external_sqldialect marker as test coverage marker. #8458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
billdirks
commented
Jul 31, 2023
|
|
||
| if TYPE_CHECKING: | ||
| from great_expectations.data_context import AbstractDataContext | ||
|
|
||
| FALSEY_VALUES = [None, [], False] | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def datetime_dataset(test_backend): |
There was a problem hiding this comment.
I've deleted this fixture and the tests that use it since they are marked as xfail with the reason that get_dataset should no longer be called. This fixture sets up data via that call.
There was a problem hiding this comment.
Thanks for cleaning this up @billdirks
| "aws_creds: mark all tests that require aws credentials", | ||
| "big: mark tests that don't have external dependencies but aren't unit tests", | ||
| "cli: mark all tests in the /cli directory.", | ||
| "cloud: mark test as being relevant to Great Expectations Cloud.", | ||
| "docs: mark a test as a docs test.", | ||
| "e2e: mark test as an E2E test.", | ||
| "external_sqldialect: mark test as requiring install of an external sql dialect.", | ||
| "google_creds: mark tests that require google creds", |
There was a problem hiding this comment.
Oh, I can't actually remove "external_sqldialect. We don't use it for our test markers but another pipeline uses it and I've left the marker in the tests.
| @@ -511,13 +511,14 @@ filterwarnings = [ | |||
| junit_family = "xunit2" | |||
| markers = [ | |||
| "all_backends: mark tests that run against all execution engine backends", | |||
| "athena: mark tests that require pyathena", | |||
Kilo59
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesblack+ruff)For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!