Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] AWS Glue script using Context Manager to catch FutureWarning #8466

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Aug 1, 2023

Follow up to #8437

  • Adding FilterWarnings to context manager
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

Comment on lines +19 to +20
# needed because GlueContext(sc) function emits the following FutureWarning: Deprecated in 3.0.0. Use SparkSession.builder.getOrCreate() instead.
with warnings.catch_warnings():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using context manager for a smaller scope

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 4ca92e9
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64c9a3daf721cd0008ead788

@ghost
Copy link

ghost commented Aug 1, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) August 1, 2023 22:00
auto-merge was automatically disabled August 1, 2023 23:00

Base branch was modified

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) August 2, 2023 00:31
@Shinnnyshinshin Shinnnyshinshin merged commit 06c29a6 into develop Aug 2, 2023
87 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the m/_/aws-athena-script-uses-context-manager-to-catch-warnings branch August 2, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants