Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] min-versions wait for unit-tests, static-analysis #8471

Merged
merged 2 commits into from Aug 2, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Aug 2, 2023

To prevent the early fanout of our Github Action workers, wait for the unit-tests, static-analysis to pass before running the min-versions tests.

This should not increase the total time of the CI.

image

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@Kilo59 Kilo59 self-assigned this Aug 2, 2023
@github-actions github-actions bot added the core label Aug 2, 2023
@ghost
Copy link

ghost commented Aug 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 75b5864
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64ca6fb157a76d0008c462f6

@Kilo59 Kilo59 merged commit 88d2f5d into develop Aug 2, 2023
46 checks passed
@Kilo59 Kilo59 deleted the m/_/min_test_run_after_checks branch August 2, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants