Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Connect to filesystem source data #8483

Merged
merged 11 commits into from Aug 9, 2023

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Aug 3, 2023

In DOC-581, @abegong requested the addition of an optional step 3 to Connect to filesystem source data - Filesystem - Single file with pandas using step 2 from the Cloud documentation.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit c75fe13
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64d3767de06096000883b0cf
😎 Deploy Preview https://deploy-preview-8483--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label Aug 3, 2023
@ghost
Copy link

ghost commented Aug 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible: can we update those links to point to the specific tab on the consolidated page they correspond to? Otherwise it looks good to me. Approved so my suggestion isn't blocking.

@kwcanuck kwcanuck merged commit 2ee8c05 into develop Aug 9, 2023
66 checks passed
@kwcanuck kwcanuck deleted the pandas-single-file-update branch August 9, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants