Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Notify on build-n-publish failure. #8495

Merged
merged 3 commits into from Aug 4, 2023

Conversation

billdirks
Copy link
Contributor

@billdirks billdirks commented Aug 4, 2023

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@@ -357,33 +357,6 @@ jobs:
# Due to the relatively small number of usage_stats tests, we deem it appropriate to test them in their entirely through pytest
run: pytest --no-sqlalchemy --aws-integration -v tests/integration/usage_statistics

notify_on_failure:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to the bottom.

py310-min-versions,
import_gx,
usage_stats_integration,
build-n-publish
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is identical to above except for adding build-n-publish.

with:
payload: |
{
"event_name": "${{ github.event_name }}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added the event_name to the message.

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billdirks billdirks enabled auto-merge (squash) August 4, 2023 18:42
@Shinnnyshinshin Shinnnyshinshin changed the title Notify on build-n-publish failure. [MAINTENANCE] Notify on build-n-publish failure. Aug 4, 2023
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 697b628
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64cd4e4abd0ae20008830e0b

@github-actions github-actions bot added the core label Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@billdirks billdirks merged commit 14bdda6 into develop Aug 4, 2023
44 checks passed
@billdirks billdirks deleted the m/_/slack-notify-on-publish-failure branch August 4, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants