Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Change default testing level from WARNING to INFO #8506

Merged
merged 3 commits into from Aug 7, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Aug 7, 2023

This change was previously not possible because some of our v12 CLI tests were checking for emitted logs as part of their failure condition. These have since been removed.

This should make debugging failing tests much easier.

Note: pytest captures any logs emitted during test execution and only displays them as part of the test failure output.
https://docs.pytest.org/en/7.1.x/how-to/logging.html#how-to-manage-logging


  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more details, see our Contribution Checklist, Coding style guide, and Documentation style guide.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit be00ab6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64d0f8daf7b77100089df52a

@Kilo59 Kilo59 self-assigned this Aug 7, 2023
@github-actions github-actions bot added the core label Aug 7, 2023
@ghost
Copy link

ghost commented Aug 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

pyproject.toml Outdated
# uncomment to adjust captured log levels
# WARNING some cli v012 tests may fail if this is altered
# log_level = "info"
# WARNING some cli v012 tests may fail if this is "info" or lower
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this warning can me removed

@Kilo59 Kilo59 enabled auto-merge (squash) August 7, 2023 14:15
@Kilo59 Kilo59 merged commit ce122b2 into develop Aug 7, 2023
51 checks passed
@Kilo59 Kilo59 deleted the m/_/test-info-logging branch August 7, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants