Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Update Docusaurus to 2.4.1 #8508

Merged
merged 19 commits into from Aug 14, 2023

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Aug 7, 2023

What is this for?

  • Security Vulnerability in our Docusaurus packages
  • Upgraded Docusaurus 2.4.1, which had additional dependencies (@svgr/webpack": "^5.5.0") which had additional security vulnerabilities.
  • nth-check is upgraded to 2.0.1 as recommended by dependabot.
    Screenshot 2023-08-10 at 6 38 47 PM
  • Deprecates UserConfigurableProfiler, which is a V2 feature.
  • Docstrings polish
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 6ae1694
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64da52953c984300088c6d00
😎 Deploy Preview https://deploy-preview-8508--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Aug 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@@ -19,11 +19,11 @@
"@cmfcmf/docusaurus-search-local": "^0.11.0",
"@docusaurus-terminology/parser": "^1.3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if plugins need to be updated too

"@mdx-js/react": "^1.6.21",
"@svgr/webpack": "^5.5.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the offending package

Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) August 14, 2023 16:13
@Shinnnyshinshin Shinnnyshinshin merged commit ff8ed71 into develop Aug 14, 2023
51 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the m/_/docusaurus-upgrade branch August 14, 2023 16:58
Shinnnyshinshin added a commit that referenced this pull request Aug 14, 2023
@Shinnnyshinshin Shinnnyshinshin restored the m/_/docusaurus-upgrade branch August 14, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants