Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Update the CTA in the Data Docs footer #8603

Merged
merged 1 commit into from Aug 22, 2023
Merged

[MAINTENANCE] Update the CTA in the Data Docs footer #8603

merged 1 commit into from Aug 22, 2023

Conversation

donaldheppner
Copy link
Member

Updates the CTA in the Data Docs footer

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 1865caa
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/64e4d19b37fe130008ecd4a0

@github-actions github-actions bot added the core label Aug 22, 2023
@ghost
Copy link

ghost commented Aug 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@donaldheppner donaldheppner merged commit 81902a2 into develop Aug 22, 2023
49 checks passed
@donaldheppner donaldheppner deleted the m/PP-502/update_data_docs_cta branch August 22, 2023 15:53
Shinnnyshinshin added a commit that referenced this pull request Aug 22, 2023
@Shinnnyshinshin
Merge branch 'develop' into m/_/scripts-idpk-example-for-fds
a29b301 
* develop:
  [MAINTENANCE] Update the CTA in the Data Docs footer (#8603)
  [MAINTENANCE] Update metrics data model to use generic value type (#8575)
  [BUGFIX] Update Docs test after DataContext Deprecation (#8599)
  [MAINTENANCE] Deprecate `BaseDataContext` and `DataContext` (#8584)
  [FEATURE] ID/PK - Update Jupyter Notebooks for FDS (#8580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFarmer NathanFarmer NathanFarmer approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@donaldheppner @NathanFarmer