[CONTRIB] fixing null eq safe for SQLAlchemy and rendering #8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
|
Hi @kenwade4 the checks are failing at cloud-tests with error "E great_expectations.exceptions.exceptions.DataContextError: "GX_CLOUD_ORGANIZATION_ID", "GX_CLOUD_ACCESS_TOKEN" arg(s) required for ge_cloud_mode but neither provided nor found in environment or in global configs ("/home/runner/.great_expectations/great_expectations.conf", "/etc/great_expectations.conf")." |
|
Hi @karthigaiselvanm sorry about the delay on this one. I'm picking up the task from Ken.
|
Comment on lines
+68
to
+70
| column_list[idx] != column_list[0], | ||
| sa.and_(column_list[idx].is_(None), column_list[0].isnot(None)), | ||
| sa.and_(column_list[idx].isnot(None), column_list[0].is_(None)), |
Shinnnyshinshin
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Hi @karthigaiselvanm thank you very much for this. Rendering and the null case both look great
Shinnnyshinshin
merged commit b0290e2
into
great-expectations:develop
48 of 49 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!