[MAINTENANCE] Remove deprecated sqlalchemy-databricks connector #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Kilo59
reviewed
Aug 30, 2023
| @@ -86,7 +86,6 @@ class _UrlSchemaError(pydantic.UrlError): | |||
| class DatabricksDsn(AnyUrl): | |||
| allowed_schemes = { | |||
| "databricks", | |||
| "databricks+connector", | |||
There was a problem hiding this comment.
Is there any reason that you can think of that someone might want to keep using the deprecated connector?
We could keep allowing it but raise a warning if it gets used.
I'm also fine with just removing it. We can always add it back if users request it.
Kilo59
approved these changes
Aug 30, 2023
Kilo59
force-pushed
the
m/remove-deprecated-databricks-connector
branch
from
8041119
to
60d2846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlalchemy-databricksis deprecated and buggy. Thedatabrics+connector://protocol will no longer be supported. Please usedatabricks://instead.invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!