[MAINTENANCE] Column Descriptive Metrics: Return id from Data Store #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
| response.raise_for_status() | ||
|
|
||
| response_json = response.json() | ||
| return uuid.UUID(response_json["data"]["attributes"]["id"]) |
There was a problem hiding this comment.
ok this is a change that makes a lot of sense
Shinnnyshinshin
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ID is needed of the metric_run to populate the CreatedResource of the ActionResult. The rest of the changes will first be implemented in the cloud repo https://github.com/great-expectations/cloud
Eventually we will likely want to rehydrate the
MetricRun&Metricswithin OSS (e.g. if used as a metric store) however for the Column Descriptive Metrics project we don't have a use currently for the rehydrated objects. In the spirit of YAGNI / not overbuilding yet this PR only returns the id of the createdMetricRuninstead of using the response payload to build aMetricRunobject with correspondingMetrics. The returned ID is used in the agent to populate theCreatedResource. Note: if/when we implement creating theMetricRun&Metricobjects in OSS, we will also need to build deserialization logic to use the appropriate metric type for validation.invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!